Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classifications are not deleted and no Exception is thrown #2555

Closed
ryzheboka opened this issue Apr 2, 2024 · 1 comment
Closed

Classifications are not deleted and no Exception is thrown #2555

ryzheboka opened this issue Apr 2, 2024 · 1 comment
Milestone
v.8.2.0

Comments

@ryzheboka
Copy link
Contributor

The transaction for deleting a Classification is wrongfully marked as "readonly". However, the resulting PersistenceException is catched in ClassificationService. The Exception there is not handled correctly.
Todo:

  • Adjust Integration Tests
  • Stop marking the tarnsaction as READONLY
  • Throw an Exception in case a database Exception occurs during deleteClassification in ClassificationService
ryzheboka added a commit to ryzheboka/taskana that referenced this issue Apr 2, 2024
@ryzheboka
Closes Taskana#2555 - Fix deleteClassification
a67dc52
ryzheboka added a commit to ryzheboka/taskana that referenced this issue Apr 4, 2024
@ryzheboka
Closes Taskana#2555 - Fix deleteClassification
f95b2f3
@ryzheboka ryzheboka moved this from Todo to Review in TASKANA Kanban Board Apr 5, 2024
ryzheboka added a commit to ryzheboka/taskana that referenced this issue May 7, 2024
@ryzheboka
Closes Taskana#2555 - Fix deleteClassification
00e43cf
ryzheboka added a commit that referenced this issue May 7, 2024
@ryzheboka
Closes #2555 - Fix deleteClassification
f4bd23b
@ryzheboka ryzheboka moved this from Review to Integrated in TASKANA Kanban Board May 14, 2024
@ryzheboka
Copy link
Contributor Author

Already integrated

gitgoodjhe pushed a commit to gitgoodjhe/taskana that referenced this issue Aug 7, 2024
@ryzheboka
Closes Taskana#2555 - Fix deleteClassification
0651efb
gitgoodjhe pushed a commit to gitgoodjhe/taskana that referenced this issue Aug 8, 2024
@ryzheboka
Closes Taskana#2555 - Fix deleteClassification
95abc13
gitgoodjhe pushed a commit that referenced this issue Aug 9, 2024
@ryzheboka @gitgoodjhe
Closes #2555 - Fix deleteClassification
d0f5c41
@gitgoodjhe gitgoodjhe added this to the v.8.2.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
TASKANA Kanban Board
Status: Released
Milestone
v.8.2.0
Development

No branches or pull requests
2 participants
@ryzheboka @gitgoodjhe