Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2271: fix hooks for github #2275

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

sfrevel
Copy link
Contributor

@sfrevel sfrevel commented May 26, 2023


Release Notes:

fixed the commit hooks for github

For the submitter:

Verified by the reviewer:

  • Commit message format → TSK-XXX: Your commit message.
  • Submitter's update to documentation is sufficient
  • SonarCloud analysis meets our standards
  • Update of the current release notes reflects changes
  • PR fulfills the ticket
  • Edge cases and unwanted side effects are tested
  • Readability

@arolfes
Copy link
Contributor

arolfes commented May 30, 2023

Please change your commit message to

Closes #2271: fix hooks for github

@sfrevel
Copy link
Contributor Author

sfrevel commented May 30, 2023

So we don't want <> ? I misunderstood this. But then I have to remove these in the template and the commit-msg examples
also... And do we want the colon or not?

@arolfes
Copy link
Contributor

arolfes commented May 30, 2023

I like the colon :-)

@mustaphazorgati : What do you say?

@arolfes arolfes linked an issue May 30, 2023 that may be closed by this pull request
@arolfes
Copy link
Contributor

arolfes commented May 30, 2023

do it without colon

@sfrevel sfrevel changed the title Closes #<2271>: fix hooks for github Closes #2271: fix hooks for github May 31, 2023
@arolfes arolfes enabled auto-merge (rebase) May 31, 2023 07:31
@arolfes arolfes merged commit 983f2ae into Taskana:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit Hooks won't work without JIRA Tickets
3 participants