App Version using View Binding #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tc2r1
added
enhancement
|
@prasad-more-12 Great Job, Please dont forget to add your name to contributors list and to star the repo. Once I see said changes I'll merge it in :D This is awesome! |
Tc2r1
approved these changes
Oct 25, 2022
|
@Tc2r1 I had my name already in contributer s list so I changed contribution from 1 to 2. |
|
@prasad-more-12 Awesome Job. Could you update with a readme similar to this one in another PR. So people can see a summary when opening your module! |
Tc2r1
added a commit
that referenced
this pull request
Oct 26, 2022
* set up app with dependencies * set up main activity with nav graph * create domain module * add data models * add data module and fake quiz repo * add string res and quiz fragment * add fragment quiz layout * add hilt injection for application & dispatchers * add normal implementation for quiz repo * add answer details dialog * add final score fragment * add unit tests boilerplate + refactor * update markdown files * Added android questions to json (#143) * Added android questions * updated CONTRIBUTERS.MD * Added Android answers (#144) * Fix Grammatical Error of Android & template answers.json files * Added answers for android quiz * Added Splash Screen in kotlin retrofit (#145) * Added a new question (#137) * Added a new question * Added three questions Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * Create CODE_OF_CONDUCT.md (#150) Added a file which contains the code of conduct because I feel its a good prograaming and open source pratice to add a code of conduct to your repositories also its one of the key features of repositreis opend under hacktoberfest to have a code of conductl, Thank You * Comments on Android Summit 2022 live #148 (#151) Co-authored-by: AndroidLion48 <> * 3 new answers are added to Answers.json file (#134) * 3 new answers are listed. * 3 new answers are listed * Updated CONTRIBUTERS .md file Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * Update auto-issue-assign.yml * Added Android Dev Summit 2022 notes (#152) * Adds Splash screen for native-java-retrofit module (#155) * Fix Grammatical Error of Android & template answers.json files * Added answers for android quiz * Adds splash screen for java-native-retrofit module Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * App Version using View Binding (#154) * 3 new answers are added to Answer.json file * Update answers.json * copied the application module folder and renamed it * added ViewBinding and modified the MainActivity class * Added ViewBnding to ScoreActivityg * added ViewBinding to DialogFragment * added ViewBinding to QuestionFragment Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * add java questions - #93 (#98) * add java questions - #93 * resolve review comments Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * HTML5_added (#128) Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * added five questions (#141) Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * provide SplashScreen that support for Android 12. (#153) * Request calls for all supported quiz language in native-java-retrofit module (#158) * Fix Grammatical Error of Android & template answers.json files * Added answers for android quiz * Adds only request calls for all quiz answers & questions based on selected quiz language for native-java-retrofit module * update as per codefactor suggestions * update as per codefactor suggestions Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> * small syntax changes. * Added Documentation and More Issues for users to tackle. (#161) * add trueOrFalse question handling * add trueOrFalse question handling and fix bug when submitting without picked answer * set up app with dependencies * set up main activity with nav graph * create domain module * add data models * add data module and fake quiz repo * add string res and quiz fragment * add fragment quiz layout * add hilt injection for application & dispatchers * add normal implementation for quiz repo * add answer details dialog * add final score fragment * add unit tests boilerplate + refactor * lint * reorder to avoid 0 * add button margin Co-authored-by: prasad-333 <37048768+prasad-333@users.noreply.github.com> Co-authored-by: mksiddiq <97515210+mksiddiq@users.noreply.github.com> Co-authored-by: Priya Singh <92670560+PriyaSingh03@users.noreply.github.com> Co-authored-by: Nudennie <9339984+Tc2r1@users.noreply.github.com> Co-authored-by: Kunal Chaturvedi <96841396+KCmean@users.noreply.github.com> Co-authored-by: Clarence Moore <92341925+AndroidLion48@users.noreply.github.com> Co-authored-by: Ayush Singh <ayushsingh12072000@gmail.com> Co-authored-by: Prasad More <69249461+prasad-more-12@users.noreply.github.com> Co-authored-by: Rishabh Kumar <rishukumar.com@gmail.com> Co-authored-by: vikrambaital <93258493+vikrambaital@users.noreply.github.com> Co-authored-by: Amit Kumar Rout <48612930+amitkroutthedev@users.noreply.github.com> Co-authored-by: Rio Arjuna <ri0arjuna@programmer.net> Co-authored-by: Nudennie White <Nudennie.White@pilottravelcenters.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add Link of GitHub Profile