[BUG] Performance Issues with Permission Box (#751)

* Create draft PR for #750 * Remove instantiated Permission boxes upon disposal. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mhareznik <101903843+mhareznik@users.noreply.github.com> Co-authored-by: peterbarancek <62284244+peterbarancek@users.noreply.github.com>
TcOpenGroup · Nov 29, 2024 · 5cde056 · 5cde056
1 parent 20a4320
commit 5cde056
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/TcOpen.Inxton/src/Security.Wpf/PermissionBox/PermissionBox.cs b/src/TcOpen.Inxton/src/Security.Wpf/PermissionBox/PermissionBox.cs
@@ -59,6 +59,13 @@ public PermissionBox()
             this.Loaded += PermissionBox_Loaded;           
         }
 
+
+        public static void RemovePermissionBox(PermissionBox boxToRemove)
+        {
+            boxToRemove.Loaded -= boxToRemove.PermissionBox_Loaded;
+            permissionBoxes.Remove(boxToRemove);
+        }
+
         private void PermissionBox_Loaded(object sender, RoutedEventArgs e)
         {
             UpdateThis();           

diff --git a/...ton.TcoInspectors.Wpf/Abstractions/InspectorDialogue/TcoInspectorDialogDialogView.xaml.cs b/...ton.TcoInspectors.Wpf/Abstractions/InspectorDialogue/TcoInspectorDialogDialogView.xaml.cs
@@ -12,6 +12,7 @@
 using System.Windows.Media.Imaging;
 using System.Windows.Shapes;
 using TcoInspectors;
+using TcOpen.Inxton.Local.Security.Wpf;
 
 namespace TcoInspectors
 {
@@ -54,6 +55,7 @@ public void Dispose()
             this.DataContextChanged -= TcoInspectorDialogView_DataContextChanged;
             if (context != null)
             {
+                PermissionBox.RemovePermissionBox(this.PermissionBoxOverrideCommand);
                 context.CloseRequestEventHandler -= (s, ev) => this.Close();
             }
         }