reverse_complement: Pre-allocate a buffer based on input size #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeXitoi
approved these changes
Feb 24, 2017
|
Great work! Please add your name in the contributors. |
TeXitoi
reviewed
Feb 24, 2017
src/reverse_complement.rs
Outdated
| let cur = f.seek(SeekFrom::Current(0))?; | ||
| let end = f.seek(SeekFrom::End(0))?; | ||
| f.seek(SeekFrom::Start(cur))?; | ||
| Ok(end as usize + 1) |
mbrubeck
force-pushed
the
reverse_complement
branch
from
170cd1c to
54b3e84
Compare
mbrubeck
force-pushed
the
reverse_complement
branch
from
54b3e84 to
d7409fd
Compare
Yes, it does. Thanks! Fixed to use |
TeXitoi
approved these changes
Feb 24, 2017
|
https://alioth.debian.org/tracker/index.php?func=detail&aid=315633&group_id=100815&atid=413122 Thanks again for these contributions! Waiting the next ones ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43. This speeds up
reverse_complement < input25000000.txtby about 40% on my system.