impl functions should use visibility of original struct / enum

[Arnavion]

The functions like augment_clap and from_subcommand are currently generated without any explicit visibility. This means if the struct / enum is inside a mod then the functions are private to the mod, even if the struct itself is pub.

Instead these functions should use the visibility of the struct / enum.

[TeXitoi]

These functions are considered implementation details. Why would you need access to them?

[Arnavion]

I don't need access to them. The codegen of your crate does.

#![feature(proc_macro)]

extern crate structopt;
extern crate structopt_derive;

mod options {
	#[derive(Debug, ::structopt_derive::StructOpt)]
	pub struct Options {
		#[structopt(subcommand)]
		pub subcommand: ::subcommands::SubCommand,
	}
}

mod subcommands {
	#[derive(Debug, ::structopt_derive::StructOpt)]
	pub enum SubCommand {
		#[structopt(name = "foo", about = "foo")]
		Foo {
			#[structopt(help = "foo", required = true)]
			bars: Vec<String>,
		},
	}
}

fn main() {
}

error[E0624]: method `from_subcommand` is private
 --> src\main.rs:7:18
  |
7 |  #[derive(Debug, ::structopt_derive::StructOpt)]
  |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0624]: method `augment_clap` is private
 --> src\main.rs:7:18
  |
7 |  #[derive(Debug, ::structopt_derive::StructOpt)]
  |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[TeXitoi]

Ha, great, a compilation bug with an example. I didn't get the problem on the read of the issue.

Thanks.