Unnecessary name sanitisation

[Fiedzia]

Clap has no problem with subcommand names starting with colon.
I need this to namespace them (users will be able to create their own, so I want standard ones not to clash witht them.

However something in structopt removes them (and anything that's not a letter) from beginning and end of subcommand name. This seems accidental.

[CreepySkeleton]

It seems like influence of rename_all. @Fiedzia could you please try with explicit #[structopt(name = ".whatever")] and see if it disappears? Better yet, past a reproducer here

[TeXitoi]

That's a feature, but you can use

#[structopt(rename_all = "verbatim")]

to manage the names by hand.

[CreepySkeleton]

@TeXitoi That's right, but I never thought that dots . or other punctuation marks should be renamed by this, rename_all meant to rename SomeCase to some-case and the like?

[CreepySkeleton]

Err, wait, there's no way to start a name with a colon except for explicit name = ":asda". @Fiedzia do you already do this?

[CreepySkeleton]

From heck docs

Characters not within words (such as spaces, punctuations, and underscores) are not included in the output string except as they are a part of the case being converted to.

Well, it looks like #[structopt(rename_all = "verbatim")] is the correct solution.

[Fiedzia]

I am explicitely setting name with name=":somevalue", that doesn't work.
rename_all = "verbatim" does work.

This behavior was surprising though, especially that using clap directly doesn't do that.

[TeXitoi]

I think we should not change the name if it is setted explicitly, but it's technically a breaking change.

[CreepySkeleton]

but it's technically a breaking change.

Technically - yes, it is, but I highly doubt that many users has been relying on this behavior. We should really ask on users.rust-lang.org or reddit

[CreepySkeleton]

@TeXitoi I think this is basically a bug, and semver states that bugfixes does not require major version bump.

I'd like to conduct a survay on users.rust-lang.org, do you mind?

[TeXitoi]

I'm OK with doing it even without asking, but feel free to ask if you prefer to be sure.

[CreepySkeleton]

@TeXitoi this is closed too