Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and improve documentation #236

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Update and improve documentation #236

merged 1 commit into from
Aug 30, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

Closes #214

@TeXitoi There are a couple of TODOs in changelog, I could use some advise there

@CreepySkeleton
Copy link
Collaborator Author

We should also update documentation in src/lib.rs, I'm working on it

@CreepySkeleton
Copy link
Collaborator Author

@TeXitoi That's the docs I've been writing for a few days. What do you think about it? If you're fine I believe this is ready to go once we're dealt with these TODOs

@TeXitoi
Copy link
Owner

TeXitoi commented Aug 30, 2019

There is strange test failure on travis.

@CreepySkeleton
Copy link
Collaborator Author

My fault, didn't see through that doc tests are actually working. I'm fixing, in the meantime, could you please state your opinion about this changes? And TODOs

Copy link
Owner

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a great improvement of the doc! Thanks a lot, and sorry to not be so reactive.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
examples/skip.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@CreepySkeleton
Copy link
Collaborator Author

CreepySkeleton commented Aug 30, 2019

Thanks a lot, and sorry to not be so reactive

Don't ever be sorry to me for thing like that! Like you said once - we volunteer our free time here and therefore have no obligation. If I get to think you're missing something I'll just ping you :)

@CreepySkeleton
Copy link
Collaborator Author

Added "nightly" feature is removed to changelog

@TeXitoi TeXitoi merged commit 8830771 into TeXitoi:master Aug 30, 2019
@CreepySkeleton CreepySkeleton deleted the docs branch August 30, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChangeLog does not mention removing raw attributes in 0.3
2 participants