Wayland & appstream metainfo fixups #1065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebonrichie
commented
Nov 27, 2024
joebonrichie
commented
- Rename the .desktop file to match the application id. This fixes window to icon associations on Wayland sessions. Without this an icon may not be associated with the window.
- Small fixups to the appstream metainfo file following the .desktop rename
Ensure the .desktop file matches the application-id, this fixes window/icon associations on Wayland. Without it the texworks icon may not be associated with the texworks open windows for example.
Fixes generation with appstream-builder following .desktop rename. Additionally, drop the .desktop from the id as it isn't recommended.
joebonrichie
added a commit
to getsolus/packages
that referenced
this pull request
Nov 27, 2024
**Summary** - Fixes appstream metainfo generation following the .desktop file rename - Patches submitted upstream TeXworks/texworks#1065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.