Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/home #97

Closed
wants to merge 28 commits into from
Closed

Feature/home #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
6abd0d0
fix: Icon, Image
hhhello0507 Jun 28, 2024
22b73a8
remove: accentColor
hhhello0507 Jun 28, 2024
352f4bd
chore: Improve Assets
hhhello0507 Jun 28, 2024
0ffcfae
Merge pull request #89 from Team-B1ND/hotfix/assets
jyw28 Jun 28, 2024
327edee
remove: teamId in Project Templates
hhhello0507 Jun 28, 2024
2741d4c
Merge pull request #90 from Team-B1ND/hotfix/build
jyw28 Jun 28, 2024
3a58f52
fix: handle refresh error
hhhello0507 Jun 30, 2024
65d83fd
Merge pull request #91 from Team-B1ND/hotfix/handling-refresh-error
jyw28 Jul 7, 2024
12cef77
build: add ADS library
jyw28 Jul 8, 2024
f92045c
feat: add ColorProvider
hhhello0507 Jul 9, 2024
e1c14c6
feat: Setting refresh indicator color
hhhello0507 Jul 9, 2024
41e3234
asset: Add new image
hhhello0507 Jul 9, 2024
5a15a40
assets: Add alimo logo
hhhello0507 Jul 9, 2024
55c153c
feat: Apply new alimo icon in LaunchScreen
hhhello0507 Jul 9, 2024
af715d6
fix: ADS conflict
hhhello0507 Jul 9, 2024
154f662
fix: async handling
leeyoonchae Jul 13, 2024
4691255
Merge pull request #92 from Team-B1ND/feature/ads
leeyoonchae Jul 22, 2024
c3ed46a
Merge remote-tracking branch 'origin/develop' into feature/home
leeyoonchae Jul 24, 2024
bedaddf
feat : ads comment
leeyoonchae Jul 25, 2024
1a36808
feat : ads notification
leeyoonchae Jul 28, 2024
b2dfca1
fix : notification
leeyoonchae Jul 28, 2024
04b9285
feat : ads NotificationDetailView
leeyoonchae Jul 28, 2024
4ff20e2
feat : add fileDestination logic
leeyoonchae Jul 30, 2024
6916adf
feat : emoji logic
leeyoonchae Jul 30, 2024
d74fbbd
feat : BookmarkView
leeyoonchae Jul 30, 2024
2148403
fix : Bookmark
leeyoonchae Jul 30, 2024
ae1f2d1
feat : Add linelimit
leeyoonchae Jul 30, 2024
cb68bc4
feat: add AlimoBottomTabBar
leeyoonchae Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Projects/App/Project.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ let project = Project.makeModule(
.SPM.FirebaseCrashlytics,
.SPM.FirebaseMessaging,
.SPM.Nuke,
.SPM.NukeUI
.SPM.NukeUI,
.SPM.ADS
],
resources: ["Resources/**"],
infoPlist: .extendingDefault(with: [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 리뷰:

  1. 모듈 추가 시 쉼표 사용이 일관성 있게 유지되도록 수정하였습니다.
  2. 새로운 SPM 패키지 "ADS"가 추가되었습니다.
  3. 누끼UI(NukeUI)와 관련하여 필요한 기능이 모두 구현되었는지 확인할 필요가 있습니다.

Expand Down
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/100.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/1024.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/114.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/120.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/128.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/144.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/152.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/16.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/167.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/172.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/180.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/196.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/20.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/216.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/256.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/29.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/40.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/48.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/50.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/512.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/55.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/57.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/58.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/60.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/64.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/66.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/72.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/76.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/80.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/87.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/88.png
View file
Open in desktop
Binary file modified Projects/App/Resources/Assets.xcassets/AppIcon.appiconset/92.png
View file
Open in desktop
21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/AddImoji.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Angry.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/BookMark.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/BookMark_none.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/BookMark_tabbar.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Chat.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/ClickedBookmark.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Copy.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Download.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/File.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Hide.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Home.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Home_none.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Image.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/LoudSpeaker.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Ok.imageset/Contents.json
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions Projects/App/Resources/Assets.xcassets/Icon/Profile.imageset/Contents.json
View file
Open in desktop

This file was deleted.

Loading