Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat :: redisualStudentPage #88 #89

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat :: redisualStudentPage #88 #89

merged 1 commit into from
Nov 20, 2024

Conversation

wjzlskxk
Copy link
Member

⛳️ 작업 내용

  • 현재 날짜 기준 외박 잔류자를 표시하는 페이지를 개발 하였습니다.
  • 현재는 프로필필사진, 이름, 반번호, 전화번호가 나오지만 추후 이보다 더 좋은 카테고리가 있다면 반영하겠습니다.

📸 스크린샷

스크린샷 2024-11-20 오전 10 01 14

@wjzlskxk wjzlskxk requested review from ftery0 and s1hyun2 November 20, 2024 01:02
s1hyun2
s1hyun2 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@s1hyun2 s1hyun2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 🥳

ftery0
ftery0 reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@ftery0 ftery0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잔류 학생은 어디에서 보여주는건가요?
사이드바에 안보여서

@wjzlskxk
Copy link
Member Author

현재 잔류학생은 외출/외박 사이드바에서 보여지도록 만들었습니다

@ftery0
Copy link
Member

ftery0 commented Nov 20, 2024

두곳 다 뜨는건가요?? 사진을 보여주세요

@wjzlskxk
Copy link
Member Author

스크린샷 2024-11-20 오전 10 41 11

서버에서 반환하는게 현재 날짜 기준 외박 잔류 학생이라 외출자는 포함되지 않습니다.

ftery0
ftery0 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ftery0 ftery0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다

@wjzlskxk wjzlskxk merged commit ac8723d into main Nov 20, 2024
1 check passed
@wjzlskxk wjzlskxk deleted the Feat/#88 branch December 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1hyun2 s1hyun2 s1hyun2 approved these changes

@ftery0 ftery0 ftery0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjzlskxk @ftery0 @s1hyun2