Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: 디스코드 웹훅 - 유저 가입 알림 구현 #203

Open
wants to merge 5 commits into
base: prod
Choose a base branch
from

Conversation

givemethatsewon
Copy link
Collaborator

📣 Related Issue

#202

📝 Summary

  • 로컬 개발 환경 설정 및 WebClient 의존성 추가
  • Discord 웹훅을 이용한 회원가입 알림 및 에러 알림 기능 구현
  • WebClient 설정 및 로깅 필터 추가로 디버깅과 모니터링 개선

🙏 Question & PR point

  • Discord 웹훅 설정과 호출 방식에 대한 검토 필요
  • 배포할 때 반드시 업데이트된 application.yml 적용 필요

Copy link

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b87cf9f.

Copy link
Contributor

@hyunw9 hyunw9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~

주말 중으로 배포해봅시다 !

Comment on lines +66 to +68
discordNotifier.sendRegistrationNotification(savedUser.getEmail(), userCount)
.subscribe(result -> System.out.println("알림 전송 완료: " + result),
error -> System.err.println("알림 전송 실패: " + error.getMessage()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옹 이 부분은 webflux라 가능한 형태인가요 ?

되게 코틀린의 함수형 패러다임과 비슷하네요~

@@ -15,4 +15,7 @@ public interface UserRepository {
void delete(User user);

User save(User user);


Long count();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가급적이면 두 줄 개행보다는 한 줄을 선호합니다 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants