Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 일지 작성 시 사진도 함께 들어가도록 수정 #131

Merged
merged 6 commits into from
Aug 30, 2024
Merged

[FEAT] 일지 작성 시 사진도 함께 들어가도록 수정 #131

merged 6 commits into from
Aug 30, 2024

Conversation

sootudio
Copy link
Contributor

#️⃣ 연관된 이슈

📝 작업 내용

  • Request DTO 수정
  • Controller, Service에서 multipart 파일을 가져와 S3에 저장하는 로직 추가

📝 남은 작업

  • 이제 가져올 때도 추가되도록 로직 수정해야 함.

@sootudio sootudio added FEAT 새로운 기능을 추가할 경우 수영 labels Aug 30, 2024
@sootudio sootudio self-assigned this Aug 30, 2024
a-young-kim
a-young-kim approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@a-young-kim a-young-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5 : 확인했습니다.

csb9427
csb9427 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!!

@sootudio sootudio merged commit 0e00178 into develop Aug 30, 2024
1 check passed
@sootudio sootudio deleted the feature/#125 branch August 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-young-kim a-young-kim a-young-kim approved these changes

@csb9427 csb9427 csb9427 approved these changes

Assignees

@sootudio sootudio

Labels
FEAT 새로운 기능을 추가할 경우 수영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 일지 작성 시 사진도 함께 들어가도록 수정
3 participants
@sootudio @a-young-kim @csb9427