Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Void Seed to replace Experience Rod early game #638

Open
wants to merge 4 commits into
base: dev/1.21.1
Choose a base branch
from

Conversation

ferriarnus
Copy link
Member

Description

Currently, the Experience Rod does not fit the idea of a "skulk" theme we want to use for exp. We can however not simply lock the item behind skulk, as it is needed for both the exp vacuum and soul binder, making it essential for progression. To remedie this, I introduce a new item "Void Seeds". This item absorbs exp from exp orbs when in the offhand of a player (similar to mending). This stored exp can then be either drunk by the player to gain levels, or transferred to a tank to use in crafting. However, it is unable to take levels from the player. Once exp has been absorbed by the player, it is stuck on the player.

The Experience Rod and Obelisk will still exist and be able to take exp from the player. We just purely delay it a bit longer, as it is a powerful tool.

TODO

  • Texture.
  • Replace Experience Rod recipe (not this PR)
  • Sword upgrade (not this PR)

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656
Copy link
Member

I like this idea, nicely thought out :)

@dphaldes dphaldes added Type-Enhancement New feature or enhancement to existing feature. MC-1.20.4 labels Mar 25, 2024
@dphaldes
Copy link
Contributor

Few gameplay notes:

  1. The void seed only works in offhand and not main hand, which is not how mending works. (mending goes main hand, offhand and then armor slots (not important for us). Maybe even add curio slots after. )
  2. Tbf, such an item such work anywhere in the inventory and not just main/offhand.
  3. The void seed xp consumption is instant. There are no drinking ticks, and it is easy for the player to use by mistake. There needs to a small drinking cycle
  4. I couldn't figure out how to add xp to a machine.

@ferriarnus
Copy link
Member Author

Few gameplay notes:

  1. The void seed only works in offhand and not main hand, which is not how mending works. (mending goes main hand, offhand and then armor slots (not important for us). Maybe even add curio slots after. )
  2. Tbf, such an item such work anywhere in the inventory and not just main/offhand.
  3. The void seed xp consumption is instant. There are no drinking ticks, and it is easy for the player to use by mistake. There needs to a small drinking cycle
  4. I couldn't figure out how to add xp to a machine.
  1. That's fair, I did offhand assuming main would be killing the mob, but that may not be true.
  2. Potentially, but I rather wouldn't search all inv slots for the item to tick it, for performance reasons.
  3. Yeah that's a good shout, I'll look into that.
  4. It should act as a fluid container, so adding it to a fluid tank should work?

@ferriarnus ferriarnus changed the base branch from dev/1.20.4 to dev/1.20.6 May 19, 2024 22:39
@ferriarnus ferriarnus changed the base branch from dev/1.20.6 to dev/1.21 June 20, 2024 20:40
@Rover656
Copy link
Member

Rover656 commented Jul 3, 2024

Where are we with this PR?

@ferriarnus
Copy link
Member Author

Besides maybe a proper texture, I think this is done if we agree with the idea

@Rover656
Copy link
Member

Rover656 commented Jul 7, 2024

I'd like to think about this more, happy to help migrate this after the reorganisation

@Rover656 Rover656 changed the base branch from dev/1.21 to dev/1.21.1 September 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.21 Type-Enhancement New feature or enhancement to existing feature.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants