Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port RefinedStorage conduits to 1.20.1 version #646

Merged
merged 18 commits into from
Jul 3, 2024

Conversation

jumanji144
Copy link

@jumanji144 jumanji144 commented Apr 4, 2024

Description

This PR aims to port the original EnderIO RefinedStorage conduits over to the modern branch.
For now this is for the 1.20.1 version, due to RS2 being a better choice for the development branch, when it is done

Closes #415

Breaking Changes

  • Modified shared conduit gui icons texture

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. MC-1.20.1 Area-Parity 1.12.2 missing features Area-Conduits Everything involving conduits labels Apr 14, 2024
@Rover656 Rover656 self-assigned this May 4, 2024
@Rover656 Rover656 added this to the 1.12.2 Parity Features milestone May 4, 2024
@Rover656 Rover656 changed the base branch from dev/1.20.1 to lts/1.20.1 May 18, 2024 10:29
@Rover656
Copy link
Member

I have updated this PR to point to the new lts/1.20.1 branch for backporting. I will likely try to port this up to 1.20.6 first - see if any modifications are needed to this PR and then merge this once that is done (to maintain feature consistency). Thanks for your work on this, and I hope this won't take too long to get to.

@ferriarnus ferriarnus merged commit 02e33c9 into Team-EnderIO:lts/1.20.1 Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Conduits Everything involving conduits Area-Parity 1.12.2 missing features MC-1.20.1 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants