Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RS2 Conduits #750

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Jul 19, 2024

Description

It seems to work now, though in some case it visually doesn't update.

TODO

  • codec
  • connection logic
  • textures

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@ferriarnus ferriarnus marked this pull request as ready for review August 14, 2024 20:20
replay_pid8464.log Outdated Show resolved Hide resolved
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested as working. Just a couple of tweaks before we can merge this.
Thank you!

@Rover656 Rover656 enabled auto-merge (squash) August 21, 2024 16:08
@Rover656 Rover656 merged commit 88d3fb4 into Team-EnderIO:dev/1.21 Aug 21, 2024
2 checks passed
@Rover656 Rover656 mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants