Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Conduit facades #771

Draft
wants to merge 5 commits into
base: dev/1.21.1
Choose a base branch
from
Draft

[WIP] Conduit facades #771

wants to merge 5 commits into from
+576 −105

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Aug 5, 2024 •
edited
Loading

Description

  • Conduit Facades (normal, transparent, hardened and transparent hardened).
  • Holding any wrench in main hand or offhand hides the facades and allows interaction under the hood.

Deferred for future:

  • Enable/disable this behaviour with shift+scroll on Yeta wrench
  • Allow showing/hiding individual conduit types

Closes #301

TODO

  • Blast resistance increase
  • Ability to place conduit bundle with no conduits (facade only)
  • Fix AE2 conduit facade interop
  • Ensure block break interactions are correct
  • Render wireframe (possibly with a BER) when the facades are hidden
  • Fix collision work when hiding facades (should still collide like a full block)
  • Config option for enable/disable conduit facade hiding functionality entirely.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. Area-Conduits Everything involving conduits MC-1.21 labels Aug 5, 2024
@Rover656 Rover656 added this to the 1.12.2 Parity Features milestone Aug 5, 2024
@turnerlewis
Copy link

You're doing gods work guys!

@Rover656 Rover656 changed the base branch from dev/1.21 to dev/1.21.1 September 30, 2024 16:40
@Rover656
feat: Initial enablement of facades. Allows a single block type and s…
bb5ac82 
…upports the "transparent" variant (in code). Facades hide when holding a wrench.

Next need to add facade items instead of using the painted slab, handle increased blast resistance and allow facades to be placed without any conduit in the space (for laying down future paths). Also need to handle break interactions.
@Rover656
feat: Added facade items and facade breaking behaviour.
7a08aa6
@Rover656
chore: Some cleanup and fixed collisions when hiding facades with a w…
e81b1d9 
…rench.
@Rover656
fix: Allow placing conduits into an existing bundle when right clicki…
ab1d9c7 
…ng the block below
@Rover656
chore: change how facades are stored and tidy up after the rebase.
944fb0f 
Conduit items now also hide facades
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryLoenwind HenryLoenwind HenryLoenwind left review comments

Assignees
No one assigned
Labels
Area-Conduits Everything involving conduits MC-1.21 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Milestone
1.12.2 Parity Features
Development

Successfully merging this pull request may close these issues.

Conduit Facades
3 participants
@Rover656 @turnerlewis @HenryLoenwind