Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conduit Speed Reworks #822

Merged
merged 6 commits into from
Oct 12, 2024
Merged

Conduit Speed Reworks #822

merged 6 commits into from
Oct 12, 2024

Conversation

Rover656
Copy link
Member

Description

Transfer Rate is the base speed of the item conduit with no upgrades, measured in Items per Cycle Tick Rate is the number of times in a tick the conduit "Cycles"

Adds two new conduit tiers: Enhanced Item Conduit and Ender Item Conduit. The maximum upgraded Ender Item Conduit can transfer 256 Items per Second.

Rates still could change, however I think this also gives a lot of power to pack devs who have specific requirements.

Still need to add textures and recipes.

The changed rates (with a temporary field not present in the PR which shows the maximum speed):

image
image
image

Feel free to make suggestions in this PR's comments.

TODO

  • Textures
  • Recipes
  • Possibly rename conduit transfer rate fields to make clear the unit?

Breaking Changes

This PR will break existing datapacks that add Item conduits. I don't imagine there are any, but in any case this will be a major version bump to 7.1.

Backport?

It should be possible to backport the speed improvements and additional tiers to 1.20.1, however it will not feature the configurability that 1.21.1 enjoys.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 added Type-RFC Request for comments. Area-Conduits Everything involving conduits Area-Datapacks MC-1.21 labels Sep 27, 2024
@Rover656 Rover656 force-pushed the feat/faster-item-conduits branch 3 times, most recently from fc70fcf to 7c27ac4 Compare September 27, 2024 14:45
@Rover656 Rover656 changed the base branch from dev/1.21 to dev/1.21.1 September 30, 2024 16:40
@Rover656 Rover656 changed the title Faster Item Conduits Conduit Speed Reworks Oct 3, 2024
@Rover656
Copy link
Member Author

Rover656 commented Oct 3, 2024

Ignore the description, I ended up hijacking this branch to make conduit ticking changes and fixes to the tooltips.
Going to merge this now as its looking a lot more correct :)

… control.

Transfer Rate is the base speed of the item conduit with no upgrades, measured in Items per Cycle
Tick Rate is the number of times in a tick the conduit "Cycles"

Adds two new conduit tiers: Enhanced Item Conduit and Ender Item Conduit.
The maximum upgraded Ender Item Conduit can transfer 256 Items per Second.

Rates still could change, however I think this also gives a lot of power to pack devs who have specific requirements.

Still need to add textures and recipes.
… the conduit

Also made ItemConduit changes backward compatible and disabled the new tiers for now, as we want to get conduits fixed first.
@Rover656 Rover656 marked this pull request as ready for review October 12, 2024 16:15
@Rover656 Rover656 merged commit 020a469 into dev/1.21.1 Oct 12, 2024
2 checks passed
@Rover656 Rover656 deleted the feat/faster-item-conduits branch October 12, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Conduits Everything involving conduits Area-Datapacks MC-1.21 Type-RFC Request for comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant