[Experiment] Replace checkstyle with spotless #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to request review from Ferri, chonky and Lilian - if you folks would like to take a look at this and see whether you'd be happy adopting this plugin & style, please let me know! |
dphaldes
requested changes
Sep 30, 2024
endercore/src/main/java/com/enderio/core/client/RenderUtil.java
Outdated
Show resolved
Hide resolved
endercore/src/main/java/com/enderio/core/client/RenderUtil.java
Outdated
Show resolved
Hide resolved
endercore/src/main/java/com/enderio/core/client/gui/widgets/ToggleImageButton.java
Outdated
Show resolved
Hide resolved
endercore/src/main/java/com/enderio/core/common/blockentity/EnderBlockEntity.java
Outdated
Show resolved
Hide resolved
Rover656
force-pushed
the
feat/spotless-experiments
branch
4 times, most recently
from
9f6cd60
to
bbb25f0
Compare
Formatting will only apply to new changes on all projects except EnderCore as a trial.
Rover656
force-pushed
the
feat/spotless-experiments
branch
from
bbb25f0
to
7b19580
Compare
Rover656
force-pushed
the
feat/spotless-experiments
branch
from
7b19580
to
834420b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is experimenting with the spotless Gradle plugin, instead of checkstyle. This will cause builds to fail if files are formatted incorrectly, but spotlessApply will automatically reformat the problematic files.
In this PR, it is fully enabled for EnderCore -but- only enabled for new changes for other subprojects, this is to keep the diff small in this PR and to not break outstanding PRs. Once the PR list is quieter I'll flip the switch and reformat the entire project.
TODO
Checklist