[Delete/#111] 필요없은 코드 삭제

Team-HMH · Nov 16, 2024 · 1cf4843 · 1cf4843
1 parent d4c4a9c
commit 1cf4843
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 463 deletions.
diff --git a/...iOS/Projects/Modules/Networks/Sources/Foundation/Request/Encoders/ParameterEncoding.swift b/...iOS/Projects/Modules/Networks/Sources/Foundation/Request/Encoders/ParameterEncoding.swift
diff --git a/.../Projects/Modules/Networks/Sources/Foundation/Request/Encoders/RequestDataValidator.swift b/.../Projects/Modules/Networks/Sources/Foundation/Request/Encoders/RequestDataValidator.swift
diff --git a/...rror/Type/RequestError/RequestError.swift → ...on/Response/Error/Type/RequestError.swift b/...rror/Type/RequestError/RequestError.swift → ...on/Response/Error/Type/RequestError.swift
@@ -26,8 +26,6 @@ extension HMHNetworkError {
         public enum ParameterEncodingError: Error, Equatable {
             case emptyParameters // 파라미터가 비어있을 때
             case missingURL // url이 없을때
-    //        case invalidJSON // json 형식에 맞지 않을때
-    //        case invalidParametersType // Parameters 형식에 맞지 않을때
             case urlEncodingFailed // url로 인코딩 실패시
             case jsonEncodingFailed // json으로 인코딩 실패시
             case unknownErr // 그 외 예기치 못한 에러
@@ -38,10 +36,6 @@ extension HMHNetworkError {
                     return "파라미터가 비어있는 에러입니다."
                 case .missingURL:
                     return "url이 없습니다"
-    //            case .invalidJSON:
-    //                return "json 형식에 맞지 않습니다."
-    //            case .invalidParametersType:
-    //                return "Parameters 형식에 맞지 않습니다"
                 case .urlEncodingFailed:
                     return "url 인코딩 시 발생한 에러입니다."
                 case .jsonEncodingFailed:

diff --git a/...Networks/Sources/Foundation/Response/Error/Type/RequestError/ParameterEncodingError.swift b/...Networks/Sources/Foundation/Response/Error/Type/RequestError/ParameterEncodingError.swift
diff --git a/...les/Networks/Sources/Foundation/Response/Error/Type/RequestError/URLValidationError.swift b/...les/Networks/Sources/Foundation/Response/Error/Type/RequestError/URLValidationError.swift
diff --git a/...ts/Modules/Networks/Tests/Sources/RequestTest/ParameterEncoderTest/JSONEncodingTest.swift b/...ts/Modules/Networks/Tests/Sources/RequestTest/ParameterEncoderTest/JSONEncodingTest.swift
@@ -12,9 +12,6 @@ import Combine
 import Core
 import Networks
 
-// 성공했을때 명확한 httpBody가 나오는지
-// jsonEncodingError가 되는 값을 주었을때 명확히 실패가 되는지
-
 struct MockJSONEncoding: JSONEncodingType {
     public init() {}
     public var jsonEncodeResult: AnyPublisher<URLRequest, HMHNetworkError.RequestError.ParameterEncodingError>!
@@ -91,81 +88,3 @@ extension JsonEncodingTest {
         wait(for: [expectation], timeout: 1.0 * Double(requestParameter.count))
     }
 }
-
-    // 이런경우의 수가 없음
-//    func test_JSONEncoding_파라미터가Nil일때_invalidJSON_에러반환() {
-//        let requestData = URLRequestMockData.validRequestData
-//        let requestParameter = EncodableParameterMockData.nilParameters
-//        
-//        let expectation = XCTestExpectation(description: "파라미터가 Nil이어서 실패했습니다!")
-//        let expectationError: HMHNetworkError.ParameterEncodingError = .invalidJSON
-//        
-//        validateEncoding(
-//            encoder: JSONEncoding(),
-//            requestData: requestData,
-//            requestParameter: requestParameter,
-//            expectation: expectation,
-//            expectationError: expectationError
-//        )
-//        
-//        wait(for: [expectation], timeout: 1.0)
-//    }
-
-    // 이런경우의 수가 없음
-//    func test_JSONEncoding_URL이Nil일때_missingURL_에러반환() {
-//        let requestData = URLRequestMockData.nilURLRequest
-//        let requestParameter = EncodableParameterMockData.validEncodableParameter
-//        
-//        let expectation = XCTestExpectation(description: "URL이 Nil이어서 실패했습니다!")
-//        let expectationError: HMHNetworkError.ParameterEncodingError = .missingURL
-//        
-//        validateEncoding(
-//            encoder: JSONEncoding(),
-//            requestData: requestData,
-//            requestParameter: requestParameter,
-//            expectation: expectation,
-//            expectationError: expectationError
-//        )
-//        
-//        wait(for: [expectation], timeout: 1.0)
-//    }
-
-    // 이런경우의 수가 없음
-//    func test_JSONEncoding_파라미터와URL둘다Nil일때_invalidJSON_에러반환() {
-//        let requestData = URLRequestMockData.nilURLRequest
-//        let requestParameter = EncodableParameterMockData.nilParameters
-//        
-//        let expectation = XCTestExpectation(description: "URL과 파라미터가 둘다 Nil이어서 (파라미터 먼저 처리) 실패했습니다!")
-//        let expectationError: HMHNetworkError.ParameterEncodingError = .invalidJSON
-//        
-//        validateEncoding(
-//            encoder: JSONEncoding(),
-//            requestData: requestData,
-//            requestParameter: requestParameter,
-//            expectation: expectation,
-//            expectationError: expectationError
-//        )
-//        
-//        wait(for: [expectation], timeout: 1.0)
-//    }
-
-    // 이런경우의 수가 없음
-
-//    func test_JSONEncoding_Encodable타입이아닐때_invalidJSON반환() {
-//        let requestData = URLRequestMockData.validRequestData
-//        let requestParameter = EncodableParameterMockData.nonEncodableParameter
-//        
-//        let expectation = XCTestExpectation(description: "Encodable타입의 객체가 아니어서 실패했습니다!")
-//        let expectationError: HMHNetworkError.ParameterEncodingError = .invalidJSON
-//        
-//        validateEncoding(
-//            encoder: JSONEncoding(),
-//            requestData: requestData,
-//            requestParameter: requestParameter,
-//            expectation: expectation,
-//            expectationError: expectationError
-//        )
-//        
-//        wait(for: [expectation], timeout: 1.0)
-//    }
-