-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#12] 이용시간 통계뷰 구현 #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우리의 염원.. 우리의 희망.. 빛이 보입니다...
수고하셨습니다 👍🍀
let hoursText = String(format: "%02d", hours) | ||
let minutesText = String(format: "%02d", minutes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💊 코드 포멧팅을 변경하여, 3시간 3분 이런 타입으로 가는 것 제안드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 이 부분 놓쳤네요 꼼꼼한 피드백 감사합니다~
func requestAuthorization() { | ||
AuthorizationCenter.shared.revokeAuthorization { result in | ||
switch result { | ||
case .success(): | ||
break | ||
case .failure(let error): | ||
print("Error for Family Controls: \(error)") | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ViewModel이 아닌 HomeView에 넣으신 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 임시로 넣은 코드입니다! 추후에 온보딩에 있는 권한 설정 뷰로 이동 예정입니다 ~
struct AppUsage: Identifiable { | ||
var id = UUID() | ||
var appId: String // 앱 고유 식별자 | ||
var appName: String // 앱 이름 | ||
var goalTime: TimeInterval // 목표 사용 시간 | ||
var usedTime: TimeInterval // 현재 사용 시간 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💊 저같은 경우에 Models폴더에 폴더링 하였는데, 논의가 필요할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
폴더링은 그렇게 가져갑시다! 완성은 아니라 폴더링을 완벽하게 하지는 않았어요
ZStack { | ||
RoundedRectangle(cornerRadius: 10) | ||
.foregroundStyle(.gray7) | ||
.frame(minWidth: 335, maxHeight: 72) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ width 정보를 UIScrenn에 대한 extension 파일로 따로 빼서, 스크린 전체 너비를 가져와야 할지 고민입니다.. 어떻게 생각하세요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사실 이 부분 뷰 너비를 지정해주는 것이 걸렸는데, 다른 기기에서 확인했을 때 오토레이아웃이 적용되어 그냥 넘겼습니다. 확실히 하려면 extension으로 빼는 것이 좋을 것 같네요 관련 레퍼런스 좀 찾아보겠습니다~ 논의해봐요!
23ad874
to
9afc735
Compare
👾 작업 내용
이용 시간 통계뷰 구현햤습니다.
🚀 PR Point
📸 스크린샷
✅ CheckList
🔗 Issue
Resolved #12