Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Set/#26] 네트워크 계층 세팅 #27

Merged
merged 10 commits into from
May 12, 2024
Merged

[Set/#26] 네트워크 계층 세팅 #27

merged 10 commits into from
May 12, 2024

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented May 10, 2024

👾 작업 내용

이전 네트워크 계층을 그대로 가져왔습니다.
사용하면서 차근차근 아키텍처, 변경된 DTO 적용하면 될 것 같아요.

🚀 PR Point

✅ CheckList

  • 오류 없이 빌드되는지 확인
  • 로그용 print문 제거
  • 불필요한 주석 제거
  • 코드 컨벤션 확인

🔗 Issue

Resolved #26

@Zoe0929 Zoe0929 added 🐰지희 지희의 issue ⚙️SET 세팅할 시 labels May 10, 2024
@Zoe0929 Zoe0929 requested a review from kim-seonwoo May 10, 2024 05:57
@Zoe0929 Zoe0929 self-assigned this May 10, 2024
@Zoe0929 Zoe0929 linked an issue May 10, 2024 that may be closed by this pull request
Copy link
Member

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이고.. 번거로우셨을텐데 수고 많으셨습니다.. 👍

Comment on lines 10 to 11
struct LogoutResponseDTO: Codable {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓요런 부분들은 이전에 괜히 만들어 놨었네요!

@Zoe0929 Zoe0929 merged commit 91c9369 into develop May 12, 2024
@Zoe0929 Zoe0929 deleted the set/#26-networkLayer branch June 19, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️SET 세팅할 시 🐰지희 지희의 issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Set] 네트워크 세팅
2 participants