Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network [#40] 홈뷰 완성 #42

Merged
merged 16 commits into from
May 30, 2024
Merged

Network [#40] 홈뷰 완성 #42

merged 16 commits into from
May 30, 2024

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented May 29, 2024

👾 작업 내용

홈 이용시간 통계뷰를 완성했습니다. (개발 쾌감 미쳤다.. 😭 )

🚀 PR Point

전체적인 부분에 앱 사용시간과 관련 값이 있어야 구현 가능하여 모든 뷰를 DeviceActicityReport 타겟으로 이동하였습니다

  • 프로그레스바의 애니메이션은 적용되지 않았습니다. 방법 더 찾아봐야 할 것 같습니다.
  • relam을 사용하지 않을 예정이라 삭제했습니다.

📸 스크린샷

구현 내용 스크린샷
홈 뷰

✅ CheckList

  • 오류 없이 빌드되는지 확인
  • 로그용 print문 제거
  • 불필요한 주석 제거
  • 코드 컨벤션 확인

🔗 Issue

Resolved #40

@Zoe0929 Zoe0929 linked an issue May 29, 2024 that may be closed by this pull request
@Zoe0929 Zoe0929 self-assigned this May 30, 2024
@Zoe0929 Zoe0929 requested a review from kim-seonwoo May 30, 2024 00:32
@Zoe0929 Zoe0929 added 🐰지희 지희의 issue 📡NETWORK API 작업 labels May 30, 2024
Copy link
Member

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 홈뷰까지!! 👍👍

Comment on lines +59 to +65
ProgressView(value: Double(totalActivity.totalTime), total: Double(totalActivity.totalGoalTime))
.foregroundStyle(.gray5)
.padding(EdgeInsets(top: 0,
leading: 20,
bottom: 0,
trailing: 20))
.tint(.whiteText)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ progressView는 withAnimation으로는 불가능한가 싶네요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 알기로는 withAnimation이 값 변화가 있을 때 애니메이션이 되는데, 이 뷰가 뜨는 시점에는 이미 값이 0에서 특정 값으로 변하는 시점이라 ,, 안되더라구요 😭

Comment on lines +136 to +163
func configHomeViewVisual() -> [String] {
var lottieTitle = "Main-\(usageGrade)-final.json"

var titleString = ""
switch usageGrade{
case "A":
lottieTitle = "Main-A-final.json"
titleString = StringLiteral.Home.usageStatusA
case "B":
lottieTitle = "Main-B-final.json"
titleString = StringLiteral.Home.usageStatusB
case "C":
lottieTitle = "Main-C-final.json"
titleString = StringLiteral.Home.usageStatusC
case "D":
lottieTitle = "Main-D-final.json"
titleString = StringLiteral.Home.usageStatusD
case "E":
lottieTitle = "Main-E-final.json"
titleString = StringLiteral.Home.usageStatusE
case "F":
lottieTitle = "Main-F-final.json"
titleString = StringLiteral.Home.usageStatusF
default:
titleString = ""
}
return [lottieTitle, titleString]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 오오 좋습니다!! 기대된다..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현시점 또 변했습니다 😎

@Zoe0929 Zoe0929 added this to the 🔭2차 스프린트🪐 milestone May 30, 2024
@Zoe0929 Zoe0929 merged commit 8e22c0f into develop May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐰지희 지희의 issue 📡NETWORK API 작업
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Network] 홈 뷰 완성
2 participants