Refactor [#59] v 1.0.0 심사 대응 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-seonwoo
approved these changes
Jun 25, 2024
Comment on lines
+94
to
+96
| let secondsTotal = milliseconds / 1000 | ||
| let hours = secondsTotal / 3600 | ||
| let minutes = (secondsTotal % 3600) / 60 |
There was a problem hiding this comment.
💊 추후에 익스텐션으로 해보는것도 좋을것같아요~!!
There was a problem hiding this comment.
추후 코드 리펙토링 진행하겠습니다~~ 감사해옹
Comment on lines
+200
to
+201
| default: | ||
| titleString = "" |
There was a problem hiding this comment.
❓이 default같은 부분에 추후에 스켈레톤을 넣는 건가요?
There was a problem hiding this comment.
아마 로딩 전에는 뷰를 띄울 수 없어서 그냥 기본 값 넣은 거라고 생각하시면 될 것 같아요! 스켈레톤은 어려울 것 같슴다 ㅜ
| struct EarnPointButton: View { | ||
| let day: Int | ||
| let status: String | ||
| @StateObject var viewModel = PointViewModel() | ||
| @ObservedObject var viewModel: PointViewModel |
Comment on lines
+15
to
+23
| ZStack { | ||
| Color(.blackground) | ||
| .ignoresSafeArea() | ||
| VStack(spacing: 10) { | ||
| SwipeView(imageNames: [.onboardingFirst, .onboardingSecond, .onboardingThird]) | ||
| .padding(.bottom, 75) | ||
| LoginButton(loginProvider: .kakao, viewModel: viewModel) | ||
| LoginButton(loginProvider: .apple, viewModel: viewModel) | ||
| } |
|
|
||
| self.sendSucessIfNeeded() | ||
| self.getChallengeType() | ||
| } | ||
| } | ||
|
|
||
| func challengeButtonTapped() { | ||
| if remainEarnPoint == 0 { | ||
| if !(statuses.contains("UNEARNED")) { |
There was a problem hiding this comment.
💊 추후에 포인트 획득 상태를 enum화 해도 좋을듯 합니다..?,
There was a problem hiding this comment.
그런데, 이 부분의 경우에는 문자열 배열에 있는지를 검사 해야해서 enum보다는 String이 더 알맞는 것 같기도 합니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
심사 대응하며 바뀐 것들 머지하고 작업 들어가는 것이 좋을 것 같습니다!
🚀 PR Point
주요 변경 내역
✅ CheckList
🔗 Issue
Resolved #59