-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor [#95] OAuthService 리펙토링 #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 🙇
@main | ||
struct DataTestApp: App { | ||
let kakaoAPIKey = Bundle.main.infoDictionary?["KAKAO_API_KEY"] as! String | ||
init() { | ||
KakaoSDK.initSDK(appKey: kakaoAPIKey) | ||
} | ||
|
||
var body: some Scene { | ||
WindowGroup { | ||
NetworkTestUI( | ||
repository: AuthRepository( | ||
authService: AuthService(requestHandler: RequestHandler()), | ||
oauthServiceFactory: OAuthServiceFactory() | ||
) | ||
) | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
신기하고 어썸하군요..
@frozen public enum HMHNetworkError: Error { | ||
case invalidRequest(RequestError) | ||
case invalidResponse(ResponseError) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어 딱히 이유는 없는데 수정하도록 하겠습니다!
👾 작업 내용
기존에 Feature에 있던 OAuth 관련 로직을 레포지토리와 Service Layer을 통해서 분리했습니다
🚀 PR Point
📸 스크린샷
✅ CheckList
🔗 Issue
Resolved #95