Fix Lorenz 63 model filtering bug #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 7 7
Lines 385 385
=======================================
Hits 352 352
Misses 33 33 ☔ View full report in Codecov by Sentry. |
|
Closing as should now be fixed in #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something seems to have changed in recent
FillArrays/Distributionsversions in the behaviour when setting mean and (co)variance parameters forMvNormalusingFillArrayslazy array typesOnesandZerosrather than explicit array initializersonesandzeros, which appears to be leading to unintended interactions between particle updates when filtering. This PR switches to using the explicit array initializers and also initializes integrator state specifically to zero rather thanundefto avoid numerical warnings fromOrdinaryDiffEq.