Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 초대코드 입력 및 온보딩 정보 입력(초대받는 측) API #20

Merged
merged 22 commits into from
Jul 10, 2023

Conversation

jun02160
Copy link
Member

@jun02160 jun02160 commented Jul 10, 2023

📌 관련 이슈

close #16

✨ 어떤 이유로 변경된 내용인지

  • qna 관련 API와의 merge 충돌 해결
  • 초대코드 입력 및 검증, 부모관계 매칭 로직
  • 초대받는 측의 온보딩 정보 입력 API

🙏 검토 혹은 리뷰어에게 남기고 싶은 말

  • git 충돌로 rebase --continue 하다가 삽질했는데 저 충돌해결 관련 커밋들 스쿼시 커밋으로 합칠까?

@jun02160 jun02160 added 🔥 Pull Request PR 날림 예준🍒 ✨Feat 새로운 기능 추가 🪄API 서버 API 통신 🧵Git Git 바보짓 했을 때 labels Jul 10, 2023
@jun02160 jun02160 requested a review from ddongseop July 10, 2023 13:04
@jun02160 jun02160 self-assigned this Jul 10, 2023
import javax.validation.constraints.NotBlank;
import javax.validation.constraints.Size;

@Getter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생성자 없어도 괜찮은거 다시 확인했음당~

import sopt.org.umbbaServer.domain.user.model.User;

import java.time.LocalTime;
import java.util.List;

@Getter
@Builder
@AllArgsConstructor(access = AccessLevel.PRIVATE)
public class OnboadringReceiveResponseDto {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Dto명에 오타 있어욥!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했슴다

@jun02160 jun02160 merged commit 76254fc into develop Jul 10, 2023
@ddongseop ddongseop deleted the feat/#16-invite_code_onboarding_info branch August 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
예준🍒 🪄API 서버 API 통신 ✨Feat 새로운 기능 추가 🧵Git Git 바보짓 했을 때 🔥 Pull Request PR 날림
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 초대코드 입력 및 온보딩 정보 입력 API
2 participants