[REFACTOR] 온보딩, 홈 화면 API 리팩토링 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into refactor/#26-onboard_main_view_api
jun02160
added
🔥 Pull Request
ddongseop
approved these changes
Jul 13, 2023
| @@ -28,25 +28,25 @@ public class ParentchildController { | |||
|
|
|||
| @PostMapping("/onboard/invite") | |||
| @ResponseStatus(HttpStatus.CREATED) | |||
| public ApiResponse<OnboardingInviteResponseDto> onboardInvite(@Valid @RequestBody OnboardingInviteRequestDto request) { | |||
| return ApiResponse.success(SuccessType.CREATE_PARENT_CHILD_SUCCESS, parentchildService.onboardInvite(request)); | |||
| public ApiResponse<OnboardingInviteResponseDto> onboardInvite(@Valid @RequestBody final OnboardingInviteRequestDto request, Principal principal) { | |||
There was a problem hiding this comment.
final 키워드를 붙이고 Principle 사용하게 바꿨구나!
나도 final 키워드 붙이게 바꿔야겠다!
| // TODO 추가 질문 답변 저장 | ||
| Parentchild parentchild = parentchildRepository.findById(request.getParentChildId()).orElseThrow( | ||
| () -> new CustomException(ErrorType.INVALID_PARENT_CHILD_RELATION) | ||
| ); | ||
| user.updateIsMeChild(!parentchild.isInvitorChild()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
close #26
✨ 어떤 이유로 변경된 내용인지
🙏 검토 혹은 리뷰어에게 남기고 싶은 말