Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 지금 몇일차 질문에 대해 문답을 나누고 있는지 저장하는 필드 추가 #53

Merged
merged 3 commits into from
Jul 17, 2023
Merged

[FEAT] 지금 몇일차 질문에 대해 문답을 나누고 있는지 저장하는 필드 추가 #53

merged 3 commits into from
Jul 17, 2023

Conversation

ddongseop
Copy link
Member

📌 관련 이슈

closed #52

✨ 어떤 이유로 변경된 내용인지

  • 최근 질문과 답변 조회에서도 홈 화면 처럼 index에 대한 정보를 주실 수 있나요? (ex: #1에 사용되는 1)
  • 일일 질문 가져올 때 qnaList 끝에 있는거 추가로 X, 필드 추가 따로 해야함

🙏 검토 혹은 리뷰어에게 남기고 싶은 말

  • 스피디 어프로브 부탁드리겠습니다!

@ddongseop ddongseop added ddongseop🍑 ✨Feat 새로운 기능 추가 🪄API 서버 API 통신 ☁️Database DB 관련 labels Jul 17, 2023
@ddongseop ddongseop requested a review from jun02160 July 17, 2023 09:12
@ddongseop ddongseop self-assigned this Jul 17, 2023
jun02160
jun02160 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@jun02160 jun02160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다!

src/main/java/sopt/org/umbbaServer/domain/qna/controller/dto/response/TodayQnAResponseDto.java
@@ -55,6 +56,7 @@ public static TodayQnAResponseDto of(User myUser, User opponentUser, QnA todayQn

return TodayQnAResponseDto.builder()
.qnaId(todayQnA.getId())
.index(count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count와 index의 구분 좋네요

@ddongseop ddongseop merged commit 4652e38 into develop Jul 17, 2023
1 check passed
@ddongseop ddongseop added the 🔥 Pull Request PR 날림 label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jun02160 jun02160 jun02160 approved these changes

Assignees

@ddongseop ddongseop

Labels
🪄API 서버 API 통신 ☁️Database DB 관련 ddongseop🍑 ✨Feat 새로운 기능 추가 🔥 Pull Request PR 날림
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 지금 몇일차 질문에 대해 문답을 나누고 있는지 저장하는 필드 추가
2 participants
@ddongseop @jun02160