Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODIFY] 사용자 맞춤형 질문 제공을 위한 로직 추가 #65

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

ddongseop
Copy link
Member

📌 관련 이슈

#64

✨ 어떤 이유로 변경된 내용인지

  • Q/A 요청사항으로 질문 리스트 보일 때 아직 안쌓인 질문은 안보이도록 처리
  • 사용자 맞춤형 질문 제공을 위한 로직 추가
    • Enum 타입 수정
    • 로직 변경
    • 테스트용 API 만들어서 테스트

🙏 검토 혹은 리뷰어에게 남기고 싶은 말

@ddongseop ddongseop added 🔥 Pull Request PR 날림 ddongseop🍑 🪄API 서버 API 통신 🔧Modify 코드 수정 (기능의 변화가 있을 때) labels Jul 19, 2023
@ddongseop ddongseop requested a review from jun02160 July 19, 2023 17:17
@ddongseop ddongseop self-assigned this Jul 19, 2023
Comment on lines +163 to +166
// 커스텀되기 전의 메인 질문 리스트를 가져옴
if (parentchild.getQnaList().size() == 1) {
List<Question> mainQuestions = questionRepository.findByTypeOrderBySectionId(MAIN);
for (Question mainQuestion : mainQuestions) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

온보딩 API 호출할 떄마다 쌓이는 문제 해결 굳굳

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

질문 필터링 어려웠을텐데 짱이다 !!!!!수고했어 ~~

@ddongseop ddongseop merged commit 8f42a50 into develop Jul 19, 2023
@ddongseop ddongseop deleted the fix/#64-edit_custom_question_logic branch August 12, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄API 서버 API 통신 ddongseop🍑 🔧Modify 코드 수정 (기능의 변화가 있을 때) 🔥 Pull Request PR 날림
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants