Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 멀티 모듈 및 SQS를 활용한 API 서버와 푸시알림 서버 분리 #92

Merged
merged 37 commits into from
Aug 12, 2023

Conversation

ddongseop
Copy link
Member

📌 관련 이슈

closed #82

✨ 어떤 이유로 변경된 내용인지

  • 멀티 모듈 및 SQS를 활용한 API 서버와 푸시알림 서버 분리
  • 이중화된 서버에 맞춘 CI/CD 적용

🙏 검토 혹은 리뷰어에게 남기고 싶은 말

  • 엄빠 화이팅

ddongseop and others added 30 commits August 8, 2023 18:14
…on_external

[REFACTOR] common과 external 모듈 분리
…fication

[REFACTOR] Notification 서버 로직 분리
@ddongseop ddongseop added 🔥 Pull Request PR 날림 예준🍒 ddongseop🍑 ✨Feat 새로운 기능 추가 🔨Refactor 코드 리펙토링 (기능 변경 없이 코드만 수정할 때) 🚀Deploy 배포 관련 labels Aug 12, 2023
@ddongseop ddongseop requested a review from jun02160 August 12, 2023 15:06
@@ -37,7 +49,7 @@ jobs:
aws-region: ap-northeast-2

# 3) 환경변수 파일 생성
- name: make application.properties 파일 생성
- name: make application.yml 파일 생성
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폴더링 변경 부탁드려욥

Copy link
Member

@jun02160 jun02160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엄빠 서버 대공사 대성공 🔥🔥

Comment on lines 68 to 75

####################################

# FCM secret key 폴더 생성
mkdir ./firebase
cd ./firebase

aws s3 cp --region ap-northeast-2 s3://${{ secrets.S3_BUCKET_NAME }}/json/umbba-fcm-firebase-adminsdk.json .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기도 umbba-api/로 해야할듯요 !!

Comment on lines 54 to 55
# application.yml 파일 생성
cd ./src/main/resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기두 ./ -> umbba-notification/

echo "${{ secrets.UMBBA_SECRET }}" >> ./application.yml

# 생성된 파일 확인
cat ./application.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 !!

Comment on lines +69 to +70
mkdir ./firebase
cd ./firebase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도!

Comment on lines 57 to 73
cd ./src/main/resources
rm application.yaml

# application.yml 파일 생성
touch ./application.yml

# GitHub-Actions 에서 설정한 값을 application.yml 파일에 쓰기
echo "${{ secrets.UMBBA_SECRET }}" >> ./application.yml

# application.yml 파일 확인
cat ./application.yml

####################################

# FCM secret key 폴더 생성
mkdir ./firebase
cd ./firebase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 폴더링 변경 부탁드려요 ~~

@ddongseop ddongseop merged commit ddb5463 into develop Aug 12, 2023
@ddongseop ddongseop deleted the refactor/#82-multi_module branch August 12, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddongseop🍑 예준🍒 🚀Deploy 배포 관련 ✨Feat 새로운 기능 추가 🔥 Pull Request PR 날림 🔨Refactor 코드 리펙토링 (기능 변경 없이 코드만 수정할 때)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 서버 분리를 위한 멀티 모듈 적용
2 participants