bugfix: 약관동의 다이얼로그 관련 qa 수정사항 반영 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s9hn
approved these changes
Feb 21, 2025
| if (shouldShow) { | ||
| showTermsAgreementDialog() | ||
| } | ||
| if (!shouldShow) return@collectWithLifecycle |
There was a problem hiding this comment.
a: isShow는 어떤가요?? shouldShow should의 의미가 코드에선 와닿지 않는 것 같아요
There was a problem hiding this comment.
음 isShown으로 가겠습니다!!
| @@ -9,6 +10,8 @@ import com.into.websoso.ui.termsAgreement.TermsAgreementDialogBottomSheet | |||
|
|
|||
| class TermsAgreementDialogFragment : | |||
| BaseDialogFragment<DialogTermsAgreementPopupMenuBinding>(R.layout.dialog_terms_agreement_popup_menu) { | |||
| private var isBottomSheetShown = false | |||
There was a problem hiding this comment.
c: 제가 보기엔 이 프로퍼티가 없어도 문제없이 동작할 것 같은데 , 어디에 쓰는 프로퍼티일까요?
There was a problem hiding this comment.
바텀시트가 떠 있는 상태를 알려주는 프로퍼티였는데 없어도 findFragmentByTag로 충분히 동작하네욤..! 감사합니다!!
| @@ -24,6 +25,7 @@ import dagger.hilt.android.AndroidEntryPoint | |||
| @AndroidEntryPoint | |||
| class TermsAgreementDialogBottomSheet : BaseBottomSheetDialog<DialogTermsAgreementBinding>(R.layout.dialog_terms_agreement) { | |||
| private val termsAgreementViewModel: TermsAgreementViewModel by viewModels() | |||
| var onDismissListener: (() -> Unit)? = null | |||
There was a problem hiding this comment.
위에서 리뷰해주신 isBottomSheetShown 프로퍼티를 사용하는 과정에서 필요해서 public으로 해놓은건데 위에 리뷰 수정하면서 이 부분도 수정하겠습니다!
m6z1
approved these changes
Feb 21, 2025
| val existingDialog = | ||
| parentFragmentManager.findFragmentByTag(TermsAgreementDialogFragment.TERMS_AGREEMENT_TAG) | ||
| val existingBottomSheet = | ||
| parentFragmentManager.findFragmentByTag("TermsAgreementDialogBottomSheet") |
There was a problem hiding this comment.
c:요 태그값도 계속 재사용하는 것 같은데 상수화 하는건 어떤가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20250221_143601.webm
Screen_recording_20250221_155706.webm
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴