Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #495 - MyPage/Setting/Setting/ChangeUserInfo & DeleteID & PushNotification 로직 DTO -> Entity 변환 및 수정 #501

Open
wants to merge 7 commits into
base: Refactor/#495/MyPage/Setting/ProfileVisibility
Choose a base branch
from
Open

[Refactor] #495 - MyPage/Setting/Setting/ChangeUserInfo & DeleteID & PushNotification 로직 DTO -> Entity 변환 및 수정 #501

wants to merge 7 commits into from

Conversation

ena-isme
Copy link
Member

@ena-isme ena-isme commented Mar 7, 2025 •
edited
Loading

⭐️Issue


🌟Motivation

  • MyPageChangeUserInfoViewModel 을 삭제하였습니다.
  • MyPageDeleteIDViewModel 와 MyPageDeleteIDViewController 을 수정하였습니다.
  • MyPagePushNotificationViewModel 을 삭제하였습니다. @Naknakk 확인 부탁!
  • MyPage/Setting 부분 PR 은 마지막입니다.

🌟Key Changes

아래와 같이 바꾸고 싶은데, 너무 많은 파일을 고쳐야할 것 같아서
모두의 리팩 끝나고 수정하려 하는데 어떠실까요?


//현재
enum Gender {
    static let male = "M"
    static let female = "F"
}

//추구하는 방향
enum Gender {
    case male
    case female
}

🌟Simulation


🌟To Reviewer


🌟Reference

@ena-isme ena-isme changed the base branch from Develop to Refactor/#495/MyPage/Setting/ProfileVisibility March 7, 2025 07:16
@ena-isme ena-isme marked this pull request as draft March 7, 2025 07:16
@ena-isme ena-isme self-assigned this Mar 7, 2025
@ena-isme ena-isme marked this pull request as ready for review March 7, 2025 09:22
@ena-isme ena-isme changed the title [Refactor] #495 /my page/setting/delete [Refactor] #495 - MyPage/Setting/Setting/ChangeUserInfo & DeleteID & PushNotification 로직 DTO -> Entity 변환 및 수정 Mar 7, 2025
@Guryss
Copy link
Member

Guryss commented Mar 8, 2025

Gender 열거형 case 활용하는 것 좋습니당!

Guryss
Guryss approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@Guryss Guryss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셧습니당!

hyowon612
hyowon612 approved these changes Mar 9, 2025
View reviewed changes
Copy link
Collaborator

@hyowon612 hyowon612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyowon612 hyowon612 hyowon612 approved these changes

@Guryss Guryss Guryss approved these changes

@Naknakk Naknakk Awaiting requested review from Naknakk Naknakk is a code owner

Assignees

@ena-isme ena-isme

Labels
e-na reviewPlz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ena-isme @Guryss @hyowon612