Generalized CommandBase and moved subsystems to Robot #129
Conversation
amikhalev
force-pushed
the
new-commandbase
branch
from
473348a
to
348aa0f
Compare
| class ToteFeed; | ||
| class Otto; | ||
|
|
||
| typedef CommandBase<class Robot> RobotCommand; |
There was a problem hiding this comment.
Is that a forward declaration inside of the template param?
amikhalev
force-pushed
the
new-commandbase
branch
from
348aa0f
to
7e6b3a5
Compare
| waitTime = config["waitTime"].as<double>(); | ||
| isWaiting = false; | ||
| Requires(claw); | ||
| Requires(&*robot->claw); |
There was a problem hiding this comment.
Oh lawd. The expression &*robot->claw made me sick. Why does it need to be like this?
There was a problem hiding this comment.
Hmm, I can't find much about this. It appears to be equivalent to &(*(robot->claw)), which from my understanding is equivalent to robot->claw. @amikhalev? Edit: A comment would be very useful here, perhaps in all of these instances.
There was a problem hiding this comment.
it's a std::unique_ptr
There was a problem hiding this comment.
This was just reverted to robot->claw, so does that work too then? Were you trying to change it from a unique_ptr to just a pointer? Does that work?
There was a problem hiding this comment.
It is no longer a std::unique_ptr
There was a problem hiding this comment.
Oh, I missed that. Thanks for the explanation.
Moved the storage of classes to the Robot class, and generalizd the code for CommandBase to work for any Robot class. This is a first step in creating PotatoSkin (common code library)
amikhalev
force-pushed
the
new-commandbase
branch
from
7e6b3a5
to
227e947
Compare
Moved the storage of classes to the Robot class, and generalizd the
code for CommandBase to work for any Robot class. This is a first step
in creating PotatoSkin (common code library)