This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
First Code Review Pass #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtticusDrakeChristianson
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DoctorSafety Just some suggestions for the code you committed. It looks really good, but when working with other people it's especially important to make sure everything is organized and well-formatted.
I have several lines with
/* TODO: ...*/indicating some things you might want to consider doing to clean your code up. You don't need to merge this pull request, but rather take a look at some of my comments to see if any improvements to the code can be made. If you make some changes, feel free to commit them to the repository to keep the team's GitHub code up to date!(To see my changes, click on the "Commits" tab and then "Add TODOs")