Fix root file parsing issue #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
|
build test apk |
|
Please add a test for this. |
Fixes #2746, by unclamping the flags between retryWithLs and force legacy file listing option in preferences. Simple test case included to ensure no crash and line parsing can be run without error.
TranceLove
force-pushed
the
bugfix/2746
branch
from
f0c8f03
to
f8f35a3
Compare
VishalNehra
previously approved these changes
Oct 10, 2021
VishalNehra
approved these changes
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By unclamping the flags between retryWithLs and force legacy file listing option in preferences, so it becomes clearer which flag should be sent to
parseFileName()instead - that is, the latter one.Issue tracker
Fixes #2746
Automatic tests
Manual tests
Done
Device: Pixel 2 emulator, rooted with https://github.com/newbit1/rootAVD then install Magisk and Busybox module
OS: Android 11
After applying the changeset, no matter the legacy list file option is enabled or not, listing files using root shall never crash the app.
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck