Fix crashes when stat failed and had to retry with ls #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
|
Build test apk |
EmmanuelMess
previously approved these changes
Oct 12, 2021
VishalNehra
dismissed
EmmanuelMess’s stale review
The base branch was changed.
VishalNehra
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By forcing flag when
executeRootCommand()executes withretryWithLsistrue.Issue tracker
Fixes #2899
Automatic tests
Manual tests
Device: Pixel 2 emulator
OS: Android 11 emulator rooted with rootAVD and magisk
Manually trigger
ShellCommandInvalidExceptionby forcingstatcommand to fail in source, then try run it with or without legacy file listing enabled.Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck