Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spotless and and code linter #3076

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

Bambooin
Copy link
Contributor

Description

Upgrade spotless and code format

Fix format violations use new code lint

Issue tracker

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Hooray, spotless found an issue:

> Task :spotlessKotlin FAILED
Step 'ktlint' found problem in 'app/src/test/java/com/amaze/filemanager/filesystem/cloud/CloudUtilTest.kt':
Error on line: 1, column: 1
class CloudTest should be declared in a file named CloudTest.kt
Just apply `./gradlew spotlessApply` to fix format violations
Copy link
Member

@EmmanuelMess EmmanuelMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes only to *.gradle, if it passes tests its ok

@VishalNehra VishalNehra merged commit 944b791 into TeamAmaze:release/3.7 Dec 23, 2021
@Bambooin Bambooin deleted the spotless branch December 24, 2021 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants