Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation buttons barely visible on dark and light mode #4211

Open
wants to merge 6 commits into
base: release/4.0
Choose a base branch
from

Conversation

Thejas775
Copy link

@Thejas775 Thejas775 commented Jul 4, 2024

Description

This PR addresses the issue where navigation buttons are barely visible on Motorola devices when using the White/Day theme. The visibility issue is caused by the navigation bar color blending with the background, making the buttons hard to see.

Issue tracker

Fixes #3535

Automatic tests

  • Added test cases

Manual tests

  • Done

Copy link
Member

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Thejas775, happy to see your interest in contributing to amaze!
but, the approach you used was not the expected solution. currently, you are changig the BG color of nav bar. the issue is to change the colors of nav icons. can you try whether something like this this works?

@Thejas775
Copy link
Author

hi @Thejas775, happy to see your interest in contributing to amaze! but, the approach you used was not the expected solution. currently, you are changig the BG color of nav bar. the issue is to change the colors of nav icons. can you try whether something like this this works?

Okay sure.

@VishnuSanal
Copy link
Member

@Thejas775 any updates here?

@Thejas775
Copy link
Author

@Thejas775 any updates here?

Hey, sorry I was busy with something. I tried the way described in the stackoverflow but it didn't work

@VishnuSanal
Copy link
Member

I tried the way described in the stackoverflow but it didn't work

oh, I have tried those when I was reviewing your PR & they worked, IIRC. you can push your changes -- I will take a look.

@Thejas775
Copy link
Author

I tried the way described in the stackoverflow but it didn't work

oh, I have tried those when I was reviewing your PR & they worked, IIRC. you can push your changes -- I will take a look.

Which one to push the new one from stack overflow?

@VishnuSanal
Copy link
Member

@Thejas775 Um... Yep, the one you were facing issues with -- the one that didn't work.

@VishnuSanal VishnuSanal added the pr-requested-changes this PR is awaiting an update from the author label Oct 13, 2024
@VishnuSanal
Copy link
Member

hi Thejas, is this still being worked upon? can I take this PR over?

@Thejas775
Copy link
Author

hi Thejas, is this still being worked upon? can I take this PR over?

Hey sorry, I was busy with something. Please take over this PR.

@VishnuSanal
Copy link
Member

  • removed code from MainActivity & AboutActivity since it was redundant. both of them inherit ThemedActivity & the same was done there too.

  • removed setting the nav bar colors since the default android colors were better than the ones we set + they were the cause of this issue leading to usability issues too.

@VishnuSanal VishnuSanal added pr-awaiting-initial-review this PR is awaiting for an initial review and removed pr-requested-changes this PR is awaiting an update from the author labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-awaiting-initial-review this PR is awaiting for an initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation buttons barely visible on Motorola devices when using White/Day theme
2 participants