-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation buttons barely visible on dark and light mode #4211
base: release/4.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Thejas775, happy to see your interest in contributing to amaze!
but, the approach you used was not the expected solution. currently, you are changig the BG color of nav bar. the issue is to change the colors of nav icons. can you try whether something like this this works?
Okay sure. |
@Thejas775 any updates here? |
Hey, sorry I was busy with something. I tried the way described in the stackoverflow but it didn't work |
oh, I have tried those when I was reviewing your PR & they worked, IIRC. you can push your changes -- I will take a look. |
Which one to push the new one from stack overflow? |
@Thejas775 Um... Yep, the one you were facing issues with -- the one that didn't work. |
hi Thejas, is this still being worked upon? can I take this PR over? |
Hey sorry, I was busy with something. Please take over this PR. |
…ult android colors were better than the ones we set + they were leading to usability issues too.
|
Description
This PR addresses the issue where navigation buttons are barely visible on Motorola devices when using the White/Day theme. The visibility issue is caused by the navigation bar color blending with the background, making the buttons hard to see.
Issue tracker
Fixes #3535
Automatic tests
Manual tests