SftpConnectDialog: Wrap open DocumentsUI intent with Intent.createChooser() to get PEM content #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
force-pushed
the
bugfix/sftpconnectdialog-select-pem
branch
from
329f8c2
to
da70e2e
Compare
TranceLove
added
the
Issue-Bug
TranceLove
force-pushed
the
bugfix/sftpconnectdialog-select-pem
branch
2 times, most recently
from
5643117
to
8d17631
Compare
TranceLove
force-pushed
the
bugfix/sftpconnectdialog-select-pem
branch
2 times, most recently
from
782fb35
to
d1f7bd1
Compare
…oser() to get PEM content To fix regressions in newer Androids that SftpConnectDialog unable to load PEM for SSH authentication. Reference: https://stackoverflow.com/questions/10002065/android-gallery-always-returns-result-canceled-to-onactivityresult
TranceLove
force-pushed
the
bugfix/sftpconnectdialog-select-pem
branch
from
d1f7bd1
to
2410b08
Compare
VishalNehra
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix regressions in newer Androids that SftpConnectDialog unable to load PEM for SSH authentication.
Reference: https://stackoverflow.com/questions/10002065/android-gallery-always-returns-result-canceled-to-onactivityresult
Manual tests
Done
Device: Fairphone 3
OS: LibremobileOS 5.0 (Android 14)
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck