-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove mistake in LE2 activity, add doenet interactive for adding rows #274
Conversation
\left[\begin{array}{cc|c} 1 & 2 & 3 | ||
\\ 4 & 5 & 6 \end{array}\right] | ||
\left[\begin{array}{cc|c} 1 & 2 & 4 | ||
\\ 1 & 3 & 5 \end{array}\right] | ||
\sim | ||
\left[\begin{array}{cc|c} 1+6 & 2+6 & 3+6 | ||
\\ 4 & 5 & 6 \end{array}\right] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually adding a constant to rows in this example is perfectly fine (since the solution satisfies
New version does not satisfy
</task> | ||
<task> | ||
<statement> | ||
<p> | ||
Add a constant multiple of one row to another row, for example: | ||
Subtract one row by another row, for example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make this a little easier than the general case, and make an interactive for the general case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping it adding might be cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 4810968
<interactive label="AT1-interactive-add-rows" platform="doenetml" width="100%"> | ||
<slate surface="doenetml"> | ||
<xi:include parse="text" href="doenet/LE2-add-rows.xml"/> | ||
</slate> | ||
</interactive> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Preview available 🚀 |
Direct link: Activity 1.2.3 |
🚀 Preview available 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this interactive, and think the corrections are great.
Hmm, this caused a bug in the PDF build. 😔 We probably need a staging branch to send PRs to that run the full build before deploying to main... |
</statement> | ||
<answer>A. Same</answer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to scaffold with <p/>
🤦♂️
Can we* configure it to have an approval trigger a full build on a PR? And then only merge if that check passes? *You |
|
Closes #19