Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mistake in LE2 activity, add doenet interactive for adding rows #274

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

StevenClontz
Copy link
Contributor

@StevenClontz StevenClontz commented Aug 27, 2024

Closes #19

Comment on lines -171 to -175
\left[\begin{array}{cc|c} 1 & 2 & 3
\\ 4 & 5 & 6 \end{array}\right]
\left[\begin{array}{cc|c} 1 & 2 & 4
\\ 1 & 3 & 5 \end{array}\right]
\sim
\left[\begin{array}{cc|c} 1+6 & 2+6 & 3+6
\\ 4 & 5 & 6 \end{array}\right]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually adding a constant to rows in this example is perfectly fine (since the solution satisfies $x+y=1$ lol). 🤦‍♂️

New version does not satisfy $x+y=1$.

</task>
<task>
<statement>
<p>
Add a constant multiple of one row to another row, for example:
Subtract one row by another row, for example:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make this a little easier than the general case, and make an interactive for the general case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping it adding might be cleaner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4810968

Comment on lines +336 to +340
<interactive label="AT1-interactive-add-rows" platform="doenetml" width="100%">
<slate surface="doenetml">
<xi:include parse="text" href="doenet/LE2-add-rows.xml"/>
</slate>
</interactive>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

🚀 Preview available 🚀

https://e5d9360c.tbil.pages.dev

@StevenClontz
Copy link
Contributor Author

Direct link: Activity 1.2.3

Copy link

🚀 Preview available 🚀

https://3311a9eb.tbil.pages.dev

Copy link
Contributor

@jkostiuk jkostiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this interactive, and think the corrections are great.

@StevenClontz StevenClontz merged commit 569c881 into main Aug 28, 2024
3 checks passed
@StevenClontz
Copy link
Contributor Author

Hmm, this caused a bug in the PDF build. 😔 We probably need a staging branch to send PRs to that run the full build before deploying to main...

</statement>
<answer>A. Same</answer>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to scaffold with <p/> 🤦‍♂️

@siwelwerd
Copy link
Contributor

siwelwerd commented Aug 29, 2024

Hmm, this caused a bug in the PDF build. 😔 We probably need a staging branch to send PRs to that run the full build before deploying to main...

Can we* configure it to have an approval trigger a full build on a PR? And then only merge if that check passes?

*You

@siwelwerd
Copy link
Contributor

Can we* configure it to have an approval trigger a full build on a PR? And then only merge if that check passes?

Looks like yes? https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-when-a-pull-request-is-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive Geometry for LE2
3 participants