Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of PR #420 "fixed typos!" #421

Closed
wants to merge 1 commit into from
Closed

Port of PR #420 "fixed typos!" #421

wants to merge 1 commit into from

Conversation

StevenClontz
Copy link
Contributor

Copying @willcaller's PR here so the preview build executes.

Copy link

🚀 Preview available 🚀

https://e8446bcd.tbil.pages.dev

@siwelwerd
Copy link
Contributor

Why didn't #420 trigger a preview? Is a PR from a fork a different kind of event?

@StevenClontz
Copy link
Contributor Author

PRs from forks don't trigger previews. If they did, they could deploy illegal material to TBIL.pages.dev without our prior review.

@StevenClontz
Copy link
Contributor Author

Work-around is to use GitHub.dev to copy a legitmate PR to a local branch and make a draft PR like this, which triggers a deploy. There's a way to make a button to approve and trigger a build without the extra rigamarole; I'll make an issue to put it on the TODO list...

@siwelwerd
Copy link
Contributor

There's a way to make a button to approve and trigger a build without the extra rigamarole; I'll make an issue to put it on the TODO list...

I was just typing a reply to ask if this was possible. Whatever we can do to make things easier for broader community members to contribute improvements, the better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants