Loading 컴포넌트 마이그레이션 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustle-dev
added
🌟 feature
hhhyyo
requested changes
Mar 14, 2022
src/components/Loading/Loading.tsx
Outdated
| const loadingStartNode = $<HTMLDivElement>('loading-start'); | ||
| const loadingEndNode = $<HTMLDivElement>('loading-end'); | ||
|
|
||
| export const Loading = ({ message }: LoadingProps) => { |
Contributor
There was a problem hiding this comment.
background 사용하는 곳이 있어서
prop으로 받아야합니다
Contributor
Author
There was a problem hiding this comment.
속성추가 완료하였습니다.👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#11
What does this PR do?
Other information
Loading 컴포넌트를 만들었지만 안에 접근성 때문에 DOM 요소에 접근하는 부분이 있습니다.
이 부분으로 인해 storybook 테스팅시 에러가 발생하는 부분이 있는데 이것을 어떤식으로 처리해야할지 찾아봐야할 것 같습니다.