Badge 컴포넌트 마이그레이션 완료 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanana1253
reviewed
Mar 24, 2022
| $size: Size; | ||
| } | ||
|
|
||
| export type BadgeInfos = { |
Member
There was a problem hiding this comment.
오호 반복되는 타입의 객체를 이런 식으로 정의하는 방법이 있네요 굿굿
jhyj0521
reviewed
Mar 24, 2022
| "dependencies": { | ||
| "@emotion/react": "^11.8.2", | ||
| "@emotion/styled": "^11.8.1", | ||
| "@svgr/webpack": "^5.5.0", |
Contributor
There was a problem hiding this comment.
svgr로 svg를 컴포넌트화 했을 때의 장점이 궁금합니다!
jhyj0521
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#24
What does this PR do?
Other information