Search 페이지 서버사이드 렌더링 구현 #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 테스트를 위해 div 요소 하나 추가했습니다.
- tabblable 요소를 가져오는 유틸함수를 hanspoon 코드에서 가져왔습니다. - 몇가지 타입 정의만 추가했어요.
- 스타일링은 미완성이지만 Dialog 컴포넌트를 작성했습니다. - auth에서만 사용되기 때문에 배경화면 받는 backgroundImg 프롭은 지웠습니다.
- dialog에서 aria-hidden 어트리뷰트 주는 대상인 root 요소 지정 id를 __next로 변경
- search page를 만들었습니다. - react-redux 실행에 필요한 babel/runtime 설치했습니다.
- auth 컴포넌트에 button 조립 등 스타일링 추가했습니다..
- auth validation을 위해 disable attribute에 대한 타입 정의 및 스타일링을 추가했습니다.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#38
What does this PR do?
search 페이지를 대충 만들어보았습니다.
Other information
TODO