Toast, BadgeList 컴포넌트 추가 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply emotion, storybook
hanana1253
reviewed
Mar 29, 2022
| import { StyledP } from './Toast.styled'; | ||
| import { ToastProps } from './Toast.types'; | ||
|
|
||
| export const Toast = ({ message }: ToastProps) => { |
Member
There was a problem hiding this comment.
저도 갖다 쓸 수 있는 토스트 컴포넌트를 만들어주셔서 감사합니다.
Member
There was a problem hiding this comment.
효원님 제가 Toast 쓰는 useToast 훅 만들었는데 detail페이지에서 가져다 쓰셔도 좋을 것 같아요.
곧 푸시할게요
useToast에 duration을 ms 단위로 전달하면 showToast라는 boolean 상태랑 displayToast라는 함수를 객체로 반환하는데
{ showToast && } 로 렌더링 리턴하고 이벤트 발생 시 displayToast를 호출만 하면 됩니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#16
What does this PR do?
Other information