-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: some users expect the top-left dropdown menu to be related with the search box #312
Comments
Done and pushed to staging, please take a look. I don't particularly like the left drawer now (on mobile). It expands on the entire height of the screen, but only uses a search box. Perhaps it would be better to only use the height of the search box? Related TODO: The navbar searchbox could be wider, at all breakpoints. |
Yes, it would be better. After all, most websites use such a behaviour (see the search box from medium.com for example).
Agree too. |
Pushed some tweaks to staging:
|
Fixed the three items above and pushed to staging. Please note that the left and right menu now have different background colors. |
There's one more thing to fix now: when the search box is expanded, we have 2 search icons in the header, which is confusing: Most websites use the following interaction: the search button (or the menu button) transforms into a 'close' button (an X) once the search box (or the menu button) is clicked, and this close button is used to collapse the search box. See a live example on TheGuardian.com (you must see the mobile version). |
Done and pushed to staging! |
One way to get rid of this confusion would be to:
The text was updated successfully, but these errors were encountered: