Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]500에러와 토큰 관련 에러 슬랙 알림 기능 추가 #128

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Hong0329
Copy link
Contributor

@Hong0329 Hong0329 commented Feb 7, 2024

📣 Related Issue

📝 Summary

  • 500에러와 401관련 에러, valid관련 에러들을 슬렉에 알림오게 하는 기능을 개발했습니다.
스크린샷 2024-02-08 오전 2 34 32

🙏 Question & PR point

📬 Reference

final String ENV_ACTIVE = env.getActiveProfiles()[0];

// 현재 프로파일이 특정 프로파일이 아니면 알림보내지 않기
// if (!env.getActiveProfiles()[0].equals("set1")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 이부분은 추후에 사용될 가능성이 있는지 궁금합니다?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠 일단은 저렇게 할 수 있구나! 정도로만 남겨놓은거긴해요! 혹시 추후에 배포 환경이랑 개발 환경을 프로파일로 구분하게 된다면 쓰일 지도 않을까 하는 생각으로..!근데 사용될 가능성에 대해서는 저도 아직 모르겠어서 일단 남겨만 놨습니닿ㅎㅎ지울까용...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아녀!!! 정말 몰라서 질문했슴다~!~!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당! 아 추가적으로 그 errorStatus에 오타가 있길래 살짝 수정했습니다아

Copy link
Member

@bo-ram-bo-ram bo-ram-bo-ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

@Hong0329 Hong0329 merged commit bac2227 into develop Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 슬랙 에러 로깅 기능 추가
2 participants