Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-handler-update option to omit updating the handler on lambda #1

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

aarsilv
Copy link

@aarsilv aarsilv commented Aug 10, 2022

With --no-handler-update this should pass in handler-update: false as an option to update() and it should then skip updating the handler in Lambda even when --handler is provided.

This also fixes the code that checks for the pending state as AWS returns the state with a capital "S".

@aarsilv aarsilv requested a review from DanRowe August 10, 2022 18:49
Copy link

@DanRowe DanRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with xml-feed-generator and it works perfect. Great work!

@aarsilv aarsilv merged commit 1227de3 into master Aug 10, 2022
@DanRowe DanRowe deleted the no-handler-update-option branch August 10, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants