fix: note render, hitfx render, rating #472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjfhsjfh
reviewed
Jan 30, 2025
prpr/src/bin.rs
Outdated
|
改完了 |
2278535805
changed the title
sjfhsjfh
reviewed
Feb 11, 2025
prpr/src/judge.rs
Outdated
| @@ -968,13 +970,13 @@ pub struct PlayResult { | |||
|
|
|||
| pub fn icon_index(score: u32, full_combo: bool) -> usize { | |||
| match (score, full_combo) { | |||
| (1000000, _) => 7, | |||
There was a problem hiding this comment.
combo数太大这里有点问题吧，是不是该改1000000, true
There was a problem hiding this comment.
本家中实测无论什么情况，只要分数是1000000就是AP，所以我改成了这样（
那我改一下吧
prpr/src/parse/pgr.rs
Outdated
| @@ -44,7 +44,7 @@ pub struct PgrNote { | |||
| position_x: f32, | |||
| hold_time: f32, | |||
| speed: f32, | |||
| floor_position: f32, | |||
| _floor_position: f32, | |||
|
以及resolve一下冲突 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.